search

CABLE-LSM / benchcab

Tool for evaluation of CABLE land surface model
https://benchcab.readthedocs.io/en/latest/
Apache License 2.0
2 stars 3 forks source link

Add install_dir option #268

Closed SeanBryan51 closed 6 months ago

SeanBryan51 commented 6 months ago

Currently benchcab assumes the compiled executables are installed under the src/offline directory, however this may not always be the case (e.g. this script installs binaries under <project_root>/bin). This change adds the install_dir option which lets the user specify the directory in which benchcab can find the built executables.

Fixes #259

codecov[bot] commented 6 months ago

Codecov Report

Attention: Patch coverage is 80.00000% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 63.95%. Comparing base (ac2cb1f) to head (51591e0). Report is 7 commits behind head on main.

Files Patch % Lines
benchcab/model.py 80.00% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #268 +/- ## ========================================== + Coverage 63.84% 63.95% +0.10% ========================================== Files 35 35 Lines 2597 2616 +19 ========================================== + Hits 1658 1673 +15 - Misses 939 943 +4 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

SeanBryan51 commented 6 months ago

Integration tests are passing. I've also tested the new functionality with a version of CABLE built using CMake which requires setting install_dir to the bin directory.