search

CABLE-LSM / benchcab

Tool for evaluation of CABLE land surface model
https://benchcab.readthedocs.io/en/latest/
Apache License 2.0
2 stars 4 forks source link

Use package_data configuration option #272

Closed SeanBryan51 closed 8 months ago

SeanBryan51 commented 8 months ago

Currently the uploaded tarball for benchcab v4.0.0 is missing the site-packages/benchcab/data directory (see https://anaconda.org/accessnri/benchcab/files). This change fixes this by replacing the include_package_data option with the package_data option in setup.cfg (see Data Files Support).

Conda package deployment was tested here in a forked repository and the uploaded tarball contains the package data directory.

Fixes #267

codecov[bot] commented 8 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 63.93%. Comparing base (ac2cb1f) to head (8794d89). Report is 6 commits behind head on main.

:exclamation: Current head 8794d89 differs from pull request most recent head 0933e46. Consider uploading reports for the commit 0933e46 to get more accurate results

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #272 +/- ## ========================================== + Coverage 63.84% 63.93% +0.09% ========================================== Files 35 35 Lines 2597 2612 +15 ========================================== + Hits 1658 1670 +12 - Misses 939 942 +3 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

Whyborn commented 8 months ago

Looks fine to merge to me.