search

CABLE-LSM / benchcab

Tool for evaluation of CABLE land surface model
https://benchcab.readthedocs.io/en/latest/
Apache License 2.0
2 stars 3 forks source link

Add ability to run custom build commands #274

Closed SeanBryan51 closed 6 months ago

SeanBryan51 commented 6 months ago

More details to follow as PR progresses.

Closes #244

codecov[bot] commented 6 months ago

Codecov Report

Attention: Patch coverage is 53.84615% with 6 lines in your changes are missing coverage. Please review.

Project coverage is 72.14%. Comparing base (59910ed) to head (650fb70). Report is 1 commits behind head on main.

Files Patch % Lines
src/benchcab/model.py 55.55% 4 Missing :warning:
src/benchcab/benchcab.py 0.00% 2 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #274 +/- ## ========================================== - Coverage 72.81% 72.14% -0.67% ========================================== Files 18 18 Lines 982 973 -9 ========================================== - Hits 715 702 -13 - Misses 267 271 +4 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

SeanBryan51 commented 6 months ago

After discussing with @ccarouge, we have decided to add support for spack and to deprecate support for legacy CABLE build systems in benchcab. This adds the requirement that users will only be able to test benchcab on branches that can be built by spack. ACCESS-NRI will help with transitioning legacy build systems to use the latest build system compatible with spack.

Moving to spack will solve existing issues around supporting bespoke build scripts (e.g. #244, #249). This is the best way forward considering support for legacy build systems is a temporary that will be deprecated sooner or later.

Closing this PR.