Bitwise comparisons: confusing message to users

CABLE-LSM / benchcab

Tool for evaluation of CABLE land surface model

https://benchcab.readthedocs.io/en/latest/

Apache License 2.0

2 stars 3 forks source link

Bitwise comparisons: confusing message to users #299

Closed ccarouge closed 2 months ago

ccarouge commented 2 months ago

Currently, the code will print to log we are running comparison tests and the success of the tests even when we run only 1 realisation. In that case, there are no comparison tasks to run. It might be good to change the messages if comparisons is empty.

https://github.com/CABLE-LSM/benchcab/blob/fc625c0fb07a52a2b9987ccf33ecfe7bd35556c7/src/benchcab/benchcab.py#L320-L326

SeanBryan51 commented 2 months ago

This reminded me of PR #291. In that PR, the log messages around fluxsite tasks and comparison tasks are improved to output the total number of tasks as well as how many succeeded/failed (for example see here). Does this address your issue?

ccarouge commented 2 months ago

Yes. And sorry the review request got lost it seems.