CABLE-LSM / benchcab

Tool for evaluation of CABLE land surface model
https://benchcab.readthedocs.io/en/latest/
Apache License 2.0
2 stars 4 forks source link

Fix compilation with custom script #71

Closed ccarouge closed 1 year ago

ccarouge commented 1 year ago

This is a quick fix for the case a custom script is provided. It fixes the issue that the mpi option might not work in the same way for the custom script as for the default build.

Considering the build code is likely to change further, the fix is applied in a simple way that might be revisited later on.

github-actions[bot] commented 1 year ago

PR Preview Action v1.2.0 :---: :rocket: Deployed preview to https://CABLE-LSM.github.io/benchcab/pr-preview/pr-71/ on branch gh-pages at 2023-05-03 01:17 UTC

ccarouge commented 1 year ago

Ah yes absolutely. I knew I was forgetting something. We really need to put the tests in an Action. I'll get to that.

ccarouge commented 1 year ago

I removed the invalid tests. I tested the code with a config.yaml file with a realisation using the default build script and one with the build script specified. Both source codes were built as intended.