CABrouwers / node-red-contrib-telnet

Apache License 2.0
3 stars 1 forks source link

inclusion of node_modules #2

Closed Steve-Mcl closed 3 years ago

Steve-Mcl commented 3 years ago

Hi, typically you should exclude node_modules from git.

When the user installs your node, npm reads the package.json file and the necessary modules get download - but only if required.

e.g. supposed the user already has fetch installed - npm will not download it again. however, as it is in your src, it will always be downloaded.

Worse still, if one of those packages you have inside node_modules has a serious security breach, the user is stuck with your version (kinda)

Unless you have intentionally done this, I would personally recommend excluding node_modules (add to git ignore) and push an update to git/npm

Some help in case you need it (ignore me otherwise)...