shapely deprecation warning during convert_polygons

[water-e]

• schimpy version: 1.4.2
• Python version: 3.9
• Operating System: Windows

Description

(py39) F:\volume_chapter>convert_polygons --input LegalDelta_edited.shp --output delta.yaml C:\Users\eli\Miniconda3\envs\py39\lib\site-packages\schimpy\schism_polygon.py:35: ShapelyDeprecationWarning: Setting custom attributes on geometry objects is deprecated, and will raise an AttributeError in Shapely 2.0

[kjnam]

It is a known issue with Shapely ver 2. Please use Shapely 1.8 for now. We will adopt ver 2 soon.

[water-e]

@kjnam Do we have a "last version with Shapely 1.0" with 1.0 as the requirement yet? Which is expected in master right now?

[kjnam]

@water-e The branch to migrate to Shapely 2.0 is not merged yet, and the master is not tagged. So, you are right, the current HEAD of the master uses Shapely 1.

[water-e]

Got it.

You might want to merge frequently from master. Or, if you think the conversion is working fine, we can do the tag requiring 1.0, merge it in right away and re-tag. This is not a good time for a development branch, which would have a staleness issue even in calmer times.

---

From: Kijin Nam @.> Sent: Friday, June 23, 2023 9:21 AM To: CADWRDeltaModeling/schimpy @.> Cc: Ateljevich, @. @.>; Mention @.***> Subject: Re: [CADWRDeltaModeling/schimpy] shapely deprecation warning during convert_polygons (Issue #27)

@water-ehttps://github.com/water-e The branch to migrate to Shapely 2.0 is not merged yet, and the master is not tagged. So, you are right, the current HEAD of the master uses Shapely 1.

— Reply to this email directly, view it on GitHubhttps://github.com/CADWRDeltaModeling/schimpy/issues/27#issuecomment-1604512110, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AG2AJC2V2KVEDP7J4EQWJ6LXMW7BJANCNFSM6AAAAAAUUSQWTA. You are receiving this because you were mentioned.Message ID: @.***>

[kjnam]

I think this is resolved now as described in #33.