CADWRDeltaModeling / vtools3

Pandas/xarray implementation of the most important functionality of vtools, emphasizing csv and netcdf as data sources.
https://cadwrdeltamodeling.github.io/vtools3/
Apache License 2.0
7 stars 1 forks source link

add godin filter based on direct convolution #15

Closed dwr-psandhu closed 4 years ago

dwr-psandhu commented 4 years ago

The current godin filter implementation uses repeated boxcar implementation. It is more efficient to use filter coefficients (FIR filters can all do this) and convolution. This is already implemented in pydsm and needs to be moved to this package.

dwr-psandhu commented 4 years ago

Done. with regression test against old vtools implementation.