search

CADmium-Co / CADmium

A CAD program that runs in the browser
https://cadmium-co.github.io/CADmium/
Other
1.42k stars 57 forks source link

remove the /CADmium suffix from the URL #112

Open MattFerraro opened 3 months ago

MattFerraro commented 3 months ago

currently when you run locally using pnpm dev, you can access the editor at http://127.0.0.1:5173/ which seems correct.

but the deployed page at https://cadmium-co.github.io/CADmium/ contains a trailing /CADmium/. Let's remove that!

sebsebmc commented 3 months ago

I believe this is a requirement of Github Pages. The formatting is always <owner-name>.github.io/<repo-name>

If we want to use just https://cadmium-co.github.io that would be an "organization"/"user" site, which requires using a repository named <organization>.github.io that is used to publish the site.

See https://docs.github.com/en/pages/getting-started-with-github-pages/about-github-pages#types-of-github-pages-sites

MattFerraro commented 3 months ago

Thanks for the research! I'm not sure there's a good solution here because I don't want to move the repo. It might be best to just bite the bullet and pay for hosting somewhere other than gh-pages.

dzervas commented 3 months ago

if we move to custom domain (also free if I'm not mistaken) this is a non-issue - and I think the best case is to use an app subdomain to have the apex domain for docs/homepage/etc.

Its-Just-Nans commented 3 months ago

Hi

I think you can just use a method like that

https://www.nieknijland.nl/blog/how-to-trigger-a-github-action-workflow-in-another-repository

  1. Create the repository cadmium-co.github.io
  2. Move most of .github/workflows/ci.yml to the new repo
  3. Change .github/workflows/ci.yml to create a dispatch event
  4. Modify the yml accordingly to trigger on this event

The final url would be https://cadmium-co.github.io/