CADmium-Co / CADmium

A CAD program that runs in the browser
https://cadmium-co.github.io/CADmium/
Other
1.46k stars 59 forks source link

Rectangle Tool does not stop after finishing Rectangle #68

Closed MattFerraro closed 5 months ago

MattFerraro commented 5 months ago

Currently, when editing a sketch you can tap "r" to activate the rectangle tool. You can click once to place the first point, then as you move the mouse around you can preview the rectangle as you decide where to place the second point. Upon clicking the second point, the rectangle is completed and gets added to the sketch correctly.

What should happen next is that you should continue to be in rectangle mode, but your mouse pointer should now be completely free: you should choosing where to place the first point of a new rectangle.

Instead what happens now is that the first point of the first rectangle seems to stay selected and your mouse cursor is already previewing a second rectangle.

huangxiaobao-cxx commented 5 months ago

I will complete this issue!

huangxiaobao-cxx commented 5 months ago

I created hte PR https://github.com/CADmium-Co/CADmium/pull/88 with the solution.

Now after using the rectangular tool, if the rectangle is continued, the first point of the rectangle will be re -drawed. I passed the local test.

MattFerraro commented 5 months ago

Thank you!