search

CADmium-Co / CADmium

A CAD program that runs in the browser
https://cadmium-co.github.io/CADmium/
Other
1.46k stars 59 forks source link

#73: add discord link, update phosphor-svelte #79

Closed jbcpollak closed 5 months ago

jbcpollak commented 5 months ago

This PR adds a Discord link.

I took the liberty of upgrading Phosphor-svelte and using its built in GitHub and Discord icons. I didn't delete the github icon svg but it should no longer be necessary. If you like this approach let me know and I can remove it.

image
av8ta commented 5 months ago

Looks great. Yes, please delete the unused svg @jbcpollak :pray:

av8ta commented 5 months ago

One suggestion, might be good if clicking the links opened a new tab rather than navigating to it from the current page.

jbcpollak commented 5 months ago

Good suggestion, I'll do both later today

jbcpollak commented 5 months ago

I applied the changes - when there is optional parameter to prevent the new tab from getting a hook to the original tab as a security precaution, but I experimented and it appears modern browsers us a safe default, so I opted not to include it to keep the code simpler.

https://mathiasbynens.github.io/rel-noopener/

av8ta commented 5 months ago

modern browsers us a safe default, so I opted not to include it to keep the code simpler.

https://mathiasbynens.github.io/rel-noopener/

Thanks I didn't know this was changed.