search

CAIDA / catalog-data

Repo which holds some panda solutions and papers
4 stars 6 forks source link

draft how_to_map_ips_to_routers #272

Open isacmlee opened 2 years ago

isacmlee commented 2 years ago

full_ID: software:bdrmapit link: https://github.com/CAIDA/catalog-data/tree/how_to_run_bdrmapit

isacmlee commented 2 years ago

I have a working branch.

https://github.com/CAIDA/catalog-data/pull/281

isacmlee commented 2 years ago

@alexmarder Hi Alex, I was able to run bdrmapIT with a ITDK node.as output without any issues, but changing the output to a SQLite3 file is giving me an error: 

Traceback (most recent call last):
  File "/Users/isaclee/opt/anaconda3/envs/bdrmapit/bin/bdrmapit", line 8, in <module>
    sys.exit(main())
  File "/Users/isaclee/opt/anaconda3/envs/bdrmapit/lib/python3.7/site-packages/scripts/bdrmapit.py", line 148, in main
    save = Save(args.sqlite, bdrmapit, replace=True)
  File "/Users/isaclee/opt/anaconda3/envs/bdrmapit/lib/python3.7/site-packages/bdrmapit/output/saveres.py", line 32, in __init__
    with open(os.path.join(dir_path, 'tables.sql')) as f:
FileNotFoundError: [Errno 2] No such file or directory: '/Users/isaclee/opt/anaconda3/envs/bdrmapit/lib/python3.7/site-packages/bdrmapit/output/tables.sql'
bhuffaker commented 2 years ago

Please add the script you are working on to the repo and then add a link to the file as a comment

isacmlee commented 2 years ago

By script do you mean the terminal commands used to run bdrmapIT? And would it just be in the same folder as the recipe?

bhuffaker commented 2 years ago

If you wrote a script include it. If you have a set of commands add them, with documentation to the README.

isacmlee commented 2 years ago

I only have a set of commands, and they are already in the README!

bhuffaker commented 2 years ago

I don't see a branch startring with 272. Please commit the branch you are working on.

isacmlee commented 2 years ago

I have a "how_to_run_bdrmapit" branch. Should I rename it to start with 272?

bhuffaker commented 2 years ago

Yes. That way github ties it to the issue and it is easier to find.

On Jan 11, 2022, at 7:05 PM, Isac Lee @.***> wrote:

I have a "how_to_run_bdrmapit" branch. Should I rename it to start with 272?

— Reply to this email directly, view it on GitHub https://github.com/CAIDA/catalog-data/issues/272#issuecomment-1010584717, or unsubscribe https://github.com/notifications/unsubscribe-auth/AECPT7JB7HZLEXYVE4ZPOYDUVTVXVANCNFSM5J2FULJA. Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub. You are receiving this because you commented.

isacmlee commented 2 years ago

Yes. That way github ties it to the issue and it is easier to find. … On Jan 11, 2022, at 7:05 PM, Isac Lee @.***> wrote: I have a "how_to_run_bdrmapit" branch. Should I rename it to start with 272? — Reply to this email directly, view it on GitHub <#272 (comment)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/AECPT7JB7HZLEXYVE4ZPOYDUVTVXVANCNFSM5J2FULJA. Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub. You are receiving this because you commented.

Just renamed it.

bhuffaker commented 2 years ago

change the name and the description to describe why someone wants to run bdrmapit.

name: How to infer which IPs belong to the same router

rewrite the introduction to explain why one needs and wants to map IPs to the same router.

On Jan 11, 2022, at 7:23 PM, Isac Lee @.***> wrote:

Yes. That way github ties it to the issue and it is easier to find. … On Jan 11, 2022, at 7:05 PM, Isac Lee @.***> wrote: I have a "how_to_run_bdrmapit" branch. Should I rename it to start with 272? — Reply to this email directly, view it on GitHub <#272 (comment)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/AECPT7JB7HZLEXYVE4ZPOYDUVTVXVANCNFSM5J2FULJA. Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub. You are receiving this because you commented.

Just renamed it.

— Reply to this email directly, view it on GitHub, or unsubscribe. Triage notifications on the go with GitHub Mobile for iOS or Android. You are receiving this because you commented.

isacmlee commented 2 years ago

I renamed the branch locally as well and when I try to push the changes onto GitHub I'm encountering this error: 

Username for 'https://github.com': isacmlee
Password for 'https://isacmlee@github.com': 
remote: Support for password authentication was removed on August 13, 2021. Please use a personal access token instead.
remote: Please see https://github.blog/2020-12-15-token-authentication-requirements-for-git-operations/ for more information.
fatal: Authentication failed for 'https://github.com/CAIDA/catalog-data.git/'

Would I have to get an access token for this repo?

bhuffaker commented 2 years ago

Honestly. I have no idea.

I would be tempted to create a new branch and just copy over the files.

Bradley

On Jan 12, 2022, at 10:10 AM, Isac Lee @.***> wrote:

I renamed the branch locally as well and when I try to push the changes onto GitHub I'm encountering this error:

Username for 'https://github.com': isacmlee Password for @.***': remote: Support for password authentication was removed on August 13, 2021. Please use a personal access token instead. remote: Please see https://github.blog/2020-12-15-token-authentication-requirements-for-git-operations/ for more information. fatal: Authentication failed for 'https://github.com/CAIDA/catalog-data.git/' Would I have to get an access token for this repo?

— Reply to this email directly, view it on GitHub https://github.com/CAIDA/catalog-data/issues/272#issuecomment-1011318880, or unsubscribe https://github.com/notifications/unsubscribe-auth/AECPT7MTEV5LDLN2KBE7F7LUVW7Y7ANCNFSM5J2FULJA. Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub. You are receiving this because you commented.

isacmlee commented 2 years ago

I created a new branch and completed the edits.

isacmlee commented 2 years ago

Should i rename this issue to "recipe how_to_map_ips_to_routers"? I believe we also have another issue "recipe: bdrmapit".

bhuffaker commented 2 years ago

Whats import is that the branch match the issue number and have a name that is meaningful 272_how_to_map_ips_to_routers.

On Jan 16, 2022, at 1:53 PM, Isac Lee @.***> wrote:

Should i rename this issue to "recipe how_to_map_ips_to_routers"? I believe we also have another issue "recipe: bdrmapit".

— Reply to this email directly, view it on GitHub https://github.com/CAIDA/catalog-data/issues/272#issuecomment-1013959530, or unsubscribe https://github.com/notifications/unsubscribe-auth/AECPT7I4DUHWJUPT4223MSDUWM447ANCNFSM5J2FULJA. Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub. You are receiving this because you commented.