CAIDA / catalog-data

Repo which holds some panda solutions and papers
4 stars 6 forks source link

some sources/media json authors set wrong #354

Closed amacaida closed 2 years ago

amacaida commented 2 years ago

Some files like 2012_as_core_ipv4_vs_ipv6_comparison.json 2011_as_core_ipv4_vs_ipv6_comparison.json

have their authors field input wrong.

Some have the incorrect format:

    "authors":[
        "person:huffaker__bradley",
        "person:claffy__kc",
        "person:hyun__young",
        "person:luckie__matthew",
        "person:cheng__justin"
    ]

Others have their person fields set wrong because there should be two underscores (__) instead of one between last name and first name:

    "authors":[
        {
            "person": "huffaker_bradley",
            "organizations": ["CAIDA, San Diego Supercomputer Center, University of California San Diego"]
        },
        {
            "person": "claffy_kc",
            "organizations": ["CAIDA, San Diego Supercomputer Center, University of California San Diego"]
        },
        {
            "person": "dainotti_alberto",
            "organizations": ["University of Napoli Federico II, Napoli, Italy"]
        },
        {
            "person": "king_alistair",
            "organizations": ["CAIDA, San Diego Supercomputer Center, University of California San Diego"]
        }
    ]

While these dont cause any errors it reports the Authors as "Not Provided" in the interface The correct format should be:

    "authors":[
        {
            "person": "huffaker__bradley",
            "organizations": ["CAIDA, San Diego Supercomputer Center, University of California San Diego"]
        },
        {
            "person": "claffy__kc",
            "organizations": ["CAIDA, San Diego Supercomputer Center, University of California San Diego"]
        },
        {
            "person": "dainotti__alberto",
            "organizations": ["University of Napoli Federico II, Napoli, Italy"]
        },
        {
            "person": "king__alistair",
            "organizations": ["CAIDA, San Diego Supercomputer Center, University of California San Diego"]
        }
    ]

Find and fix.

jes089 commented 2 years ago

For "Media", "authors" is not a valid query, the catalog-ui is looking for a presenters field, which is why it doesn't show up.

To fix this, we may want to:

amacaida commented 2 years ago

Media can also be youtube videos, which may have a creator/author but not necessarily a presenter (although many of them are videos of presentations so they do have presenters, but in theory it could just be an animation with captions)

jes089 commented 2 years ago

So perhaps Media should have authors or presenters? And for media that does not relate to a "person" that spot can be left empty?

jes089 commented 2 years ago

After talking to Bradley: