CAIDA / catalog-data

Repo which holds some panda solutions and papers
3 stars 6 forks source link

Set UC licenses for all recipes #629

Closed amacaida closed 1 year ago

amacaida commented 1 year ago

Issue from kc: can you also make sure all recipes have UCSD licenses?

Since it's a recipe, it should probably be the uc_research_use_license

bhuffaker commented 1 year ago

From https://copyright.universityofcalifornia.edu/faqs/#h

# Copyright (c) 2023 The Regents of the University of California
# All Rights Reserved
amacaida commented 1 year ago
  1. I thought we could use the "Licenses" field for this? e.g. for https://catalog.caida.org/recipe/how_to_annotate_as_relationships_with_geographic_annotations under Licenses it says "Not Provided"? Or not what its intended for?
  2. Once its decided what to do, can one of the catalog REUs be tasked on this?
bhuffaker commented 1 year ago

That works for the recipe as a whole, but if we want people to actually include the license it would make sense to put them at the top of the code. Maybe even include a link to the recipe

# Copyright (c) 2023 The Regents of the University of California
# All Rights Reserved
use os
.....
bhuffaker commented 1 year ago

@VdotR please add the following license to the start of each script and script file in the recipes:

# Copyright (c) 2023 The Regents of the University of California
# All Rights Reserved
VdotR commented 1 year ago

Just to make sure, script and script file includes all files that ends with '.py' and '.md'?

bhuffaker commented 1 year ago

Add to the bottom of the recipe README.md.

Copyright (c) 2023 The Regents of the University of California
All Rights Reserved

Add to the top of all the scripts python or otherwise

#  Copyright (c) 2023 The Regents of the University of California
# All Rights Reserved
VdotR commented 1 year ago

Just created pull request #652

amacaida commented 1 year ago

Sorry @VdotR I didn't catch this sooner -- the copyright shouldn't all say 2023; technically they should be the year that the content was written. The year indicates the year that the work was first published, effectively implying that the copyright doesn't cover the years prior to 2023.

To do it right: look for the creation date of each recipe and use that year for the copyright.

https://stackoverflow.com/questions/7551664/how-to-find-the-date-of-the-first-commit-of-files-in-git

Possibly use the git command in the link above and group the recipes by year, then VSCode search and replace the existing 2023 copyright with the correct year for those recipes?

VdotR commented 1 year ago

@amacaida No worries I'll redo the task accordingly. I would try to write a python script first just as what I did for the current version of the issue, but i'll do it manually if I have to. Thanks for catching the error!

VdotR commented 1 year ago

@amacaida Hi I added the license based on year of first commit at #655

VdotR commented 1 year ago

Task should be completed #655