[x] Have you checked the diffs (of new code) for stray console logs, and removed them?
[x] Have you checked the diffs (of new code) for un-used imports and comments, and removed them?
[x] Have you tested edge cases that you have thought of? (when the variable is undefined, invalid TYPE, when there are many items in an array, when there are very few)
Issue
Before, when the doi field was case sensitive, part of the output for a given paper with the link associated with doi instead of DOI in the id_object.json file was as follows:
The doi associated url should be its own field outside of the access array.
Fix
After making the script check for DOI regardless of case (using .upper() method), the output for a given paper, where the doi field is not fully uppercase, was correct:
Before merging:
Issue
Before, when the
doi
field was case sensitive, part of the output for a given paper with the link associated withdoi
instead ofDOI
in theid_object.json
file was as follows:The doi associated url should be its own field outside of the access array.
Fix
After making the script check for
DOI
regardless of case (using .upper() method), the output for a given paper, where thedoi
field is not fully uppercase, was correct:Notes