search

CAIDA / libparsebgp

Lightweight parser for binary BGP, BMP and MRT routing data
https://bgpstream.caida.org
BSD 2-Clause "Simplified" License
8 stars 8 forks source link

Adding BGP-LS code for review. #31

Closed ojasgupta closed 6 years ago

ojasgupta commented 7 years ago

Hi! Alistair,

Kindly take a quick look at the implementation of BGP_LS_DECODE. I haven't implemented the destroy, dump and clear functions yet. Let me know what do you think.

Thanks, Ojas

ojasgupta commented 7 years ago

Thanks @alistairking for such a detailed feedback on the code. I will check all the comments and make changes accordingly. Yes, you are right, I tried to integrate the existing code but now I will only take it as a reference. I will make sure to address the issues regarding reading from the buffer in my next PR. I will revamp the code as per your comments. Thanks again for your time.