Closed tztsai closed 5 months ago
This all looks good. I've cherry-picked the relevant commits to a new branch and force pushed. You will need to pull the changes again (probably best to do this to a new branch, as I have ignored the last commit for now (CNP2 check)).
I've also done a first pass of a review (still need to check Cluster.py
and ML.py
). I've also checked that there is correspondence in the outputs of packdata.npy
and auxil.npy
to packdata.nc
and all looks good so far. I found that approximately 70% of the data are nans
. I've written some code to do these checks which could be integrated into the testing PR. I will do a proper review tomorrow but I suspect it'll be mostly on style and the addition of comments.
The intention is to convert input and output data files into a couple of integrated files with a more structured data format, like
pandas.DataFrame
orxarray.Dataset
, replacing the current multitude oftxt
files.ML
task into a single DataFrame and store it into a CSV file.packdata
andauxil
into a single xarray Dataset and store it into a NetCDF file.auxil.npy
andpackdata.npy
withpackdata.nc
.