CALIPSO-project / SPINacc

A spinup acceleration procedure for land surface models (LSM)
4 stars 0 forks source link

Convert the input and output data into integrated datasets in `pd.DataFrame` and `xr.Dataset` #34

Closed tztsai closed 3 months ago

tztsai commented 5 months ago

The intention is to convert input and output data files into a couple of integrated files with a more structured data format, like pandas.DataFrame or xarray.Dataset, replacing the current multitude of txt files.

ma595 commented 3 months ago

This all looks good. I've cherry-picked the relevant commits to a new branch and force pushed. You will need to pull the changes again (probably best to do this to a new branch, as I have ignored the last commit for now (CNP2 check)).

I've also done a first pass of a review (still need to check Cluster.py and ML.py). I've also checked that there is correspondence in the outputs of packdata.npy and auxil.npy to packdata.nc and all looks good so far. I found that approximately 70% of the data are nans. I've written some code to do these checks which could be integrated into the testing PR. I will do a proper review tomorrow but I suspect it'll be mostly on style and the addition of comments.