Filtering done before calling `compute_metrics` so that all metrics get filtered profiles

CAMI-challenge / OPAL

OPAL: Open-community Profiling Assessment tooL

https://cami-challenge.github.io/OPAL/

Apache License 2.0

27 stars 6 forks source link

Filtering done before calling `compute_metrics` so that all metrics get filtered profiles #39

Closed dkoslicki closed 2 years ago

dkoslicki commented 4 years ago

Currently filtering only done in binary metrics. After discussing with @fernandomeyer , it seems better to filter before calling compute_metrics so all metrics get the filtered versions

fernandomeyer commented 4 years ago

Now implemented in 4facfba901ee9ccaf0a73011d1ef1925ffca8a57 and 385d0615212dc63a2dfe002339d36d2ab27e0965 and currently in dev.

dkoslicki commented 4 years ago

@fernandomeyer What are your thoughts on merging dev into master? It would let us close this issue (and probably other issues as well).