CAMeL-Lab / TOIA-2.0

2 stars 0 forks source link

Bug: error when interacting by voice with avatars on Player #80

Closed AMChierici closed 1 year ago

AMChierici commented 1 year ago

I get this error (full text below screenshot) on the player, when I start speaking with an avatar (interact by voice). Sometimes it works for a while, then I get this error. I then refresh the page, and it goes away.

Screen Shot 2022-09-19 at 3 29 41 PM
TypeError: Cannot read properties of null (reading 'split')
recordUserRating
src/pages/Player.js:268
  265 | 
  266 | const recordUserRating = function (rate) {
  267 |     // record the rating for the user
> 268 |     const vidID = videoID.split("/"); // splitting by delimeter
      | ^  269 | 
  270 | 
  271 |     const options = {
View compiled
onChange
src/userRating/ratingWords.js:57
  54 |   skipFillVideo();
  55 | 
  56 |   // recording the user rating
> 57 |   recUserRating(newValue);
     | ^  58 |   console.log("rated!");
  59 | }}
  60 | onChangeActive={(event, newHover) => {
View compiled
▼ 20 stack frames were expanded.
handleClear
node_modules/@mui/material/Rating/Rating.js:435
HTMLUnknownElement.callCallback
node_modules/react-dom/cjs/react-dom.development.js:3945
invokeGuardedCallbackDev
node_modules/react-dom/cjs/react-dom.development.js:3994
invokeGuardedCallback
node_modules/react-dom/cjs/react-dom.development.js:4056
invokeGuardedCallbackAndCatchFirstError
node_modules/react-dom/cjs/react-dom.development.js:4070
executeDispatch
node_modules/react-dom/cjs/react-dom.development.js:8243
processDispatchQueueItemsInOrder
node_modules/react-dom/cjs/react-dom.development.js:8275
processDispatchQueue
node_modules/react-dom/cjs/react-dom.development.js:8288
dispatchEventsForPlugins
node_modules/react-dom/cjs/react-dom.development.js:8299
(anonymous function)
node_modules/react-dom/cjs/react-dom.development.js:8508
batchedEventUpdates$1
node_modules/react-dom/cjs/react-dom.development.js:22396
batchedEventUpdates
node_modules/react-dom/cjs/react-dom.development.js:3745
dispatchEventForPluginEventSystem
node_modules/react-dom/cjs/react-dom.development.js:8507
attemptToDispatchEvent
node_modules/react-dom/cjs/react-dom.development.js:6005
dispatchEvent
node_modules/react-dom/cjs/react-dom.development.js:5924
unstable_runWithPriority
node_modules/scheduler/cjs/scheduler.development.js:468
runWithPriority$1
node_modules/react-dom/cjs/react-dom.development.js:11276
discreteUpdates$1
node_modules/react-dom/cjs/react-dom.development.js:22413
discreteUpdates
node_modules/react-dom/cjs/react-dom.development.js:3756
dispatchDiscreteEvent
node_modules/react-dom/cjs/react-dom.development.js:5889
▲ 20 stack frames were expanded.
This screen is visible only in development. It will not appear if the app crashes in production.
Open your browser’s developer console to further inspect this error.  Click the 'X' or hit ESC to dismiss this message.
bordernone commented 1 year ago

which branch?

AMChierici commented 1 year ago

I am on the generate-variants branch.

PS -- did you incorporate changes that Ali made last week? I could no longer see the suggestions working on the player this time.

bordernone commented 1 year ago

I haven't yet.

bordernone commented 1 year ago

Can you try doing these?

  1. run docker-compose -f docker-compose-dev.yml down -v
  2. Pull changes on generate-variants branch
  3. Run docker-compose -f docker-compose-dev.yml build toia-dm phpMyAdmin
  4. Run docker-compose -f docker-compose-dev.yml up toia-dm phpMyAdmin
  5. Open the terminal for toia-dm container
  6. Run pip install friendlywords
  7. Run python2 PATCH.py
  8. Once it completes, can you export the database. When you're exporting it, can you click on custom then at the bottom of the page, enable add create database
  9. Please send the exported file to me.
bordernone commented 1 year ago

just checked my inbox. nevermind

AMChierici commented 1 year ago

Ha, the file I sent you I didn’t do ‘enable add create database’ — do you need that? I can do it later tonight

Alberto M. Chierici

LinkedIn ( https://www.linkedin.com/in/albertochierici/ ) | ** Twitter ( https://twitter.com/AlbertoMChi )

On Mon, Sep 19 2022 at 3:58 pm, Bishnu Dev < @.*** > wrote:

just checked my inbox. nevermind

— Reply to this email directly, view it on GitHub ( https://github.com/CAMeL-Lab/TOIA-2.0/issues/80#issuecomment-1250923174 ) , or unsubscribe ( https://github.com/notifications/unsubscribe-auth/ACAG6AF6CILFTYI5IX6ER6TV7BIOTANCNFSM6AAAAAAQQATVFI ). You are receiving this because you authored the thread. Message ID: <CAMeL-Lab/TOIA-2 . 0/issues/80/1250923174 @ github. com>

bordernone commented 1 year ago

Ha, the file I sent you I didn’t do ‘enable add create database’ — do you need that? I can do it later tonight Alberto M. Chierici LinkedIn ( https://www.linkedin.com/in/albertochierici/ ) | Twitter ( https://twitter.com/AlbertoMChi ) On Mon, Sep 19 2022 at 3:58 pm, Bishnu Dev < **@.*** > wrote: just checked my inbox. nevermind — Reply to this email directly, view it on GitHub ( #80 (comment) ) , or unsubscribe ( https://github.com/notifications/unsubscribe-auth/ACAG6AF6CILFTYI5IX6ER6TV7BIOTANCNFSM6AAAAAAQQATVFI ). You are receiving this because you authored the thread. Message ID: <CAMeL-Lab/TOIA-2 . 0/issues/80/1250923174 @ github. com>

I imported the db. No need.

bordernone commented 1 year ago

This should be fixed in #90 Can you please test?

AMChierici commented 1 year ago

Yes, tested. This is solved.