search

CANopenNode / CANopenEditor

CANopen Object Dictionary Editor
GNU General Public License v3.0
133 stars 62 forks source link

New option --edsfile #130

Open modbw opened 2 months ago

modbw commented 2 months ago

When option --edsfile is given and a xdd file was loaded a eds file is saved with the given name. This allows to have xdd as single source of truth in VCS repo.

nimrof commented 2 months ago

When option --edsfile is given and a xdd file was loaded a eds file is saved with the given name. This allows to have xdd as single source of truth in VCS repo.

Hi @modbw, Thanks for taking the time to make the pr.

I am currently working on a rewrite of importer/exporter https://github.com/CANopenNode/CANopenEditor/issues/122, as part of that work we should be able to convert any format that can be imported into anything that can be exported with edssharp

Could it be a alternative to your pr if we could export eds file from edssharp? EDSSharp --infile something.xdd --outfile something.eds

modbw commented 2 months ago

That would totally match my requirements. Usecase is integration of EDSSharp into my CI/CD pipeline where all files except xdd are genereated. So, I need eds and md export. I have a pull request for md export ready but if you come up with a different solution thats fine. One thing would be to have multiple exports in one step to save some EDSharp calls. Something like EDSSharp --infile something.xdd --outfile something.eds --outfile something.md.

nimrof commented 2 months ago

That would totally match my requirements. Usecase is integration of EDSSharp into my CI/CD pipeline where all files except xdd are genereated. So, I need eds and md export.

Ahh, nice. That sounds like a good idea, and is something i might use myself. Hope to get it ready over the weekend.

I have a pull request for md export ready but if you come up with a different solution thats fine.

There are two .md generators, is it DocumentationGenMarkup or NetworkPDOreport your want? https://github.com/CANopenNode/CANopenEditor/blob/main/libEDSsharp/DocumentationGenMarkup.cs https://github.com/CANopenNode/CANopenEditor/blob/main/libEDSsharp/NetworkPDOreport.cs

Not sure how to do NetworkPDOreport as it needs multiple input files (or a file that contains multiple "eds") so that may take more time

One thing would be to have multiple exports in one step to save some EDSharp calls. Something like EDSSharp --infile something.xdd --outfile something.eds --outfile something.md.

I see the need, will gladly accept a pr. :)

PS: There are multiple .md exporters so you will probably need to use --type select the one that you want.

nimrof commented 2 months ago

Hi @modbw, Waiting for comments from the others on #131, but does that work for you?