CANopenNode / CANopenEditor

CANopen Object Dictionary Editor
GNU General Public License v3.0
120 stars 60 forks source link

Exporter writes lowercase "i" to "ı" when exporting CanOpenNode #34

Closed ihsanliturk closed 1 year ago

ihsanliturk commented 1 year ago

I'm using Turkish language settings. When I try to export CanOpenNode command, it exports "identitiy" as "ıdentity". I can correct this with a simple find/replace, but it will be better corrected in the source code.

Here is the output in OD.h file:

struct {
    uint8_t highestSub_indexSupported;
    uint32_t vendor_ID;
    uint32_t productCode;
    uint32_t revisionNumber;
    uint32_t serialNumber;
} x1018_ıdentity;
trojanobelix commented 1 year ago

might be fixed in ea8c040021f9dbbaeaaa311c428bb02a42605d00. Please test!

myildirim10 commented 1 year ago

I am also having problems with Turkish characters. Namely,

So I wrote a simple 'python' code. If you run it where your OD.c and OD.h files are, it will make the necessary changes. You can make minor changes to the python code if there are different bugs that need to be changed. Bugfix_OD_Files.zip

trojanobelix commented 1 year ago

Which version do you have tested?

myildirim10 commented 1 year ago

Which version do you have tested?

I tested in this version: v4.0-51-g2d9b1ad

trojanobelix commented 1 year ago

It makes more sense to test the actual binaries where a lot of bug are fixed. Also this bug (hopefully).

Please give a feedback after testing the actual binaries, if your are happy with the fixes for this problem.

trojanobelix commented 1 year ago

Will be closed in a few days due to lack of feedback