search

CANopenNode / CANopenEditor

CANopen Object Dictionary Editor
GNU General Public License v3.0
142 stars 64 forks source link

Adding some missing comments #96

Closed nimrof closed 7 months ago

nimrof commented 7 months ago

Only 493 missing comments left :)

a few places i have change function from public -> private

trojanobelix commented 7 months ago

Looks good. Merge!

CANopenNode commented 7 months ago

Only 493 missing comments left :)

One more reason, why to remove obsolete large files like CanOpenXDD.cs, CanOpenXML.cs, Bridge.cs

@trojanobelix, what do you think about it? (see https://github.com/CANopenNode/CANopenEditor/pull/77#issuecomment-2024952840)

trojanobelix commented 7 months ago

Agree for Bridge and CanOpenXML, not sure about CanOpenXDD. But we will see which stuff is needed.

CANopenNode commented 7 months ago

Agree for Bridge and CanOpenXML, not sure about CanOpenXDD. But we will see which stuff is needed.

There if CanOpenXDD_1_1, which is fully operational. CanOpenXDD is older implementation of an older version of the same standard and is not working well.

trojanobelix commented 7 months ago

I know, but unfortunately some test programmes only support the old version. I know that I therefore needed the XML V1.0 export more often than I would have liked, and I was very glad that CANopenEditor supports the export.

But I don't want to argue against it in principle.

Or perhaps one of you knows another good converter for CANopen files. It's really not the main task of the software.

But being able to import as many formats as possible would, in my opinion, be in the target focus. Nothing is more annoying than having all the necessary information in an (albeit old) configuration format but not being able to import it.

nimrof commented 7 months ago

I do not have a need to remove support a format if it still in use, especially if it is in use by someone that is a active contributor to the project.

CANopenNode commented 7 months ago

I know, but unfortunately some test programmes only support the old version.

I didn't know for that. Than it should stay, I think.