CANopenNode / CanOpenSTM32

CANopenNode on STM32 microcontrollers.
Other
292 stars 116 forks source link

Parameter mismatch in CO_CANinterrupt_TX #15

Closed jafem closed 1 year ago

jafem commented 2 years ago

There is a parameter argument mismatch in CO_CANinterrupt_TX, see CanOpenSTM32/stm32f0xx_can/Core/CANOpen_STM32F0xx/CO_driver_STM32F0xx.c CanOpenSTM32/stm32f3xx_can/Core/CANOpen_STM32F3xx/CO_driver_STM32F3xx.c

It is declared as void CO_CANinterrupt_TX(CO_CANmodule_t *CANmodule, uint32_t MailboxNumber)

but used as

void HAL_CAN_TxMailbox0CompleteCallback(CAN_HandleTypeDef *hcan){
    CO_CANinterrupt_TX(hcan,CAN_TX_MAILBOX0);
}
void HAL_CAN_TxMailbox1CompleteCallback(CAN_HandleTypeDef *hcan){
    CO_CANinterrupt_TX(hcan,CAN_TX_MAILBOX0);
}
void HAL_CAN_TxMailbox2CompleteCallback(CAN_HandleTypeDef *hcan){
    CO_CANinterrupt_TX(hcan,CAN_TX_MAILBOX0);
}
MaJerle commented 2 years ago

@HamedJafarzadeh for you, no?

HamedJafarzadeh commented 2 years ago

@jafem You are right. Although that won't interfere with the actual stack, because we didn't use that argument in that function, but still your point is valid and needs to be removed. I'll fix that in the next revisions.

HamedJafarzadeh commented 2 years ago

@MaJerle Can you mark it as Pending fix or something similar so I don't forget it.

MaJerle commented 2 years ago

Sure - you are now assigned and flag is added.

HamedJafarzadeh commented 1 year ago

We can close this.