search

CARA-ch / pmp-issues

Open issues or discussions regarding the PMP PoC
1 stars 0 forks source link

CH EMED ch-dosage-1 constraint is broken #24

Closed dvribeira closed 5 months ago

dvribeira commented 5 months ago

Copied from email:

The constraint is broken in CH EMED, its definition does not do what the description states hence it does not enforce sequence = 1 when using split dosage. I will create an issue to get it fixed in CH EMED, but it is not so trivial as it may seem. Once fixed, it should do what it says:

  • If there’s only one dosage (base dosage), it shall not contain the sequence field.
  • If there’s more than one dosage, the base dosage shall contain the sequence field and its value shall be 1.

Some other constraint definitions affecting dosage might be reviewed as a result to check whether they are broken, or they should be completed/improved to allow proper validation of the dosage slicing.

Alternatively, we could drop this constraint and just add sequence = 1 as a fixed value constraint for base dosage (i.e. base dosage would always have sequence = 1 whether there’s split dosage or not). @CARA-ch/pmp-coordination Happy to hear all the implementers' opinion on this one before bringing the issue to CH EMED.

sep-proactive commented 5 months ago

I agree to always have sequence = 1 for the base dosage, whether ther is split dosage or not.

CheriGey commented 5 months ago

Our preference is to just add clarity to the constraint. Currently, Soarian is using the presence of dosage.Sequence on dosage-1 to indicate whether this is a Split Dose order or not but can make the code change to support this request if necessary.

dejajs commented 5 months ago

just implemented in PRESCO: monodose -> no sequence multidose -> sequence 1, 2, etc open to change if necessary

iherveOCSIN commented 5 months ago

@dvribeira question/proposition de solution envoyée à CH EMED, en attente de réponse de leur part

dvribeira commented 5 months ago

https://github.com/hl7ch/ch-emed/issues/263

dvribeira commented 5 months ago

The proposed fix for the constraint has been implemented by CH EMED, to be released with its next version (5.0.0) and integrated into CH EMED EPR with its next version (TBD). Since this broken constraint is not blocking, no further steps will be taken on our side.