Closed federico-carrara closed 1 month ago
Attention: Patch coverage is 94.39252%
with 6 lines
in your changes missing coverage. Please review.
Project coverage is 87.20%. Comparing base (
692429e
) to head (35c2901
). Report is 1 commits behind head on main.
Files | Patch % | Lines |
---|---|---|
src/careamics/lightning/lightning_module.py | 93.33% | 3 Missing :warning: |
src/careamics/models/lvae/noise_models.py | 62.50% | 3 Missing :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Description
This PR finally implements a working training loop for the lightining module
VAEModule
.training_step
andvalidation_step
plus all the required methods. We also fixed some bugs in the configs (pydantic
model) describing the different model components.Changes Made
training_step
andvalidation_step
in the lightningVAEModule
(plus other related methods).VAEAlgorithmmConfig
.RunningPSNR
class inmetrics.py
.pydantic
models (e.g.,lvae_model.py
,nm_model.py
)Things that can be improved
validation_step
requires some additional methods for computing the PSNR at each epoch. These methods are currently within theVAEModule
since require some of its attributes. If possible, it would be nice to move this methods out of the lightning module to have something cleaner.Please ensure your PR meets the following requirements: