CARLI / vufind

A library resource discovery portal designed and developed for libraries by libraries
GNU General Public License v2.0
5 stars 0 forks source link

Make Select Item box re-sizeable by user #377

Closed gibsonjc closed 5 years ago

gibsonjc commented 6 years ago

KNX - ...the select item box is not re-sizable by the use. For example, this box has a lot of items and it would be handy to resize the box allowing me to see more than one or two items at a time.

screen shot 2018-08-30 at 3 08 24 pm

Screenshot from Chrome 68.0.x.

This is another possible enhancement for future request functionality.

[JG: In my testing, I always see 5 items in the box (unless there are fewer than 5 to choose from, then the box shrinks).]

cedelis commented 5 years ago

In TEST.

Note: adding the "resizable" functionality from jquery-ui has a layout side-effect. The 'Select Item' label, list control, and submit button are on separate rows. Previously, they were all on the same row. I don't think this is a show-stopper (I sort of like it better this way, personally). What do you think?

dmcmpbll commented 5 years ago

I agree that having the label, list control, and submit button on separate rows seems fine to me too.

I checked in Chrome, IE, and Firefox and it resized and functioned as I expected.

On my phone in Safari on Prod (so without the edits) the display box shows the first item in the list, so "any item", then when you tap on the list it shows all entries in the list and the user can select one or multiple as desired. prod

On my phone in Safari on Test (so with the edit), the display box shows some dots, then when you tap on the list it shows all entries in the list and the user can select one or multiple as desired. Can the mobile display show the first list item again? Since once a user taps on the list it shows all the entries, I don't think this is too big of an issue if it cannot be fixed for mobile. test

cedelis commented 5 years ago

@dmcmpbll Can you look at TEST now? For mobile devices, I set an initial height for the resizable list control (large enough for the 'any item' option to display).

dmcmpbll commented 5 years ago

yes, that looks great on TEST on my phone now- the "any item" option displays.

As expected, there was no change on my computer for IE, Firefox, or Chrome.

gibsonjc commented 5 years ago

Ready for Prod

cedelis commented 5 years ago

In PROD