CARLI / vufind

A library resource discovery portal designed and developed for libraries by libraries
GNU General Public License v2.0
5 stars 0 forks source link

Add new Technical Specifications field to Description Tab #398

Closed gibsonjc closed 5 years ago

gibsonjc commented 5 years ago

This is to add a new field to the Description tab in CARLI's RecordDataFormatterFactory.php similar to the "Description of Work" field (SolrMarc.php function getDescriptionOfWork):

M5. New suggested function name: getTechnicalSpecifications

Field Label: Technical Specifications

Fields [Indicators] [Subfields] to display:

344 [any indicators] ['a', 'b', 'c', 'd', 'e', 'f', 'g', 'h'] 345 [any indicators] ['a', 'b', '3'] 346 [any indicators] ['a', 'b', '3'] 347 [any indicators] ['a', 'b', 'c', 'd', 'e', 'f'] 348 [any indicators] ['a', 'b', '3']

Placement of new $spec line: after Scale

Part of Phase 2 #265

gibsonjc commented 5 years ago

Example records on Test/Devel:

344 - https://i-share-test.carli.illinois.edu/vf-aru/Record/ARUdb.451171#description 345 - https://i-share-test.carli.illinois.edu/vf-aru/Record/ARUdb.451176#description 346 - https://i-share-test.carli.illinois.edu/vf-aru/Record/ARUdb.451176#description 347 - https://i-share-test.carli.illinois.edu/vf-aru/Record/ARUdb.451171#description 348 - ?

cedelis commented 5 years ago

In TEST

gibsonjc commented 5 years ago

@cedelis Thanks, your part looks good! We have three changes to make to my specification:

  1. I have improperly conflated too many fields together here. Please remove 347 and 348 from getTechnicalSpecifications, leaving 344, 345, and 346 only. (347 will be addressed below; 348 will be addressed at another time in another way.)

  2. We'd like to change the Field Label: Technical Specifications to A/V Characteristics instead.

  3. We need a new field set up just for 347 because it really doesn't belong with the others:

S10. New suggested function name: getDigitalCharacteristics Field Label: Digital Characteristics Field [Indicators] [Subfields] to display: 347 [any indicators] ['a', 'b', 'c', 'd', 'e', 'f'] Placement of new $spec line: after A/V Characteristic (name changed above!)

/**
 * Get an array of digital characteristics information.
 *
 * @return array
 */
public function getDigitalCharacteristics()
{
    return $this->getFieldArray('347', ['a', 'b', 'c', 'd', 'e', 'f']);
}
cedelis commented 5 years ago

@gibsonjc I've made these changes and they are now in TEST

gibsonjc commented 5 years ago

This looks good, Ready for Prod

cedelis commented 5 years ago

In PROD