search

CARLI / web-reports

Web Reports Web Based Reporting Tool
2 stars 0 forks source link

Refresh interval for right sidebar is not cancelled when user toggles sidebar off #101

Open patrickzurek opened 8 years ago

patrickzurek commented 8 years ago

The timer interval set by $interval( function(){ $scope.refreshRightSidebar(); }, 10000); in the RecentReportsCtrl that is responsible for refreshing the "Recently Completed Reports" sidebar gets started even when the user has the sidebar togged off. This causes unnecessary calls to the server and should be cancelled when the user toggles the sidebar off and re-enabled if/when the user toggles it back on.

gibsonjc commented 8 years ago

At our meeting today we discussed that this should be fixed in our implementation sooner or later, and should definitely be fixed before posting the code to GitHub, but is not high priority right now.