search

CARLI / web-reports

Web Reports Web Based Reporting Tool
2 stars 0 forks source link

Average running time statistic not being recorded on prod #107

Open patrickzurek opened 8 years ago

patrickzurek commented 8 years ago

It seems that the Python Django files that contained the code to implement and record the average report running time statistic were not pushed to production when the other statistics changes were.

The view code on the statistics page was pushed, the Django schema was updated and the mysql database table was changed to accommodate the new column on production already but the logic to record the data was not pushed so viewing the stats page on prod just shows a series of 0.0s.

I'm going to push the two missing files to production now. I feel confident making this change without prior notice because the change has already been tested by us on devel, it only involves moving the two missing files over to prod.

Can someone with a working staff account (non-NNN_XXXX) please run a test report a few times (the same report in succession) on prod. Of course you won't be able to verify that the averaging is actually accurate but you will notice if something breaks :)

I can't test myself because if I use my DPU_PAT account I will skew the general collection of statistics. Remember that staff accounts are not counted towards them.

Feel free to close the ticket once you've checked that the numbers are showing up in the avg. running time column in /stats/

patrickzurek commented 8 years ago

I thought it would be a quick change to make earlier, but then I realized I would need to do something to account for all the already ran report metadata with times of 0 in the database that would affect the results. I'll push it tomorrow when folks are at their computers.

patrickzurek commented 8 years ago

While preparing the files to move to prod, I discovered a problem on devel. There's a mistake in the way I'm recording and calculating the average running times of the reports. In order to fix this I need to alter the django model and one of the database fields. It's easy but a little tedious, so I'm going to switch to getting the navbar working for authenticated users on the report-list page first then return to this.

gibsonjc commented 8 years ago

After our meeting discussion today, I'm marking this one as Accepted, but it is a low priority.