Fix file info formatting error - Githubissues

CARTAvis / carta-backend

Source code repository for the backend component of CARTA, a new visualization tool designed for the ALMA, the VLA and the SKA pathfinders.

https://cartavis.github.io/

GNU General Public License v3.0

22 stars 11 forks source link

Fix file info formatting error #1256

Closed pford closed 1 year ago

pford commented 1 year ago

Description

What is implemented or fixed? Fix #1218 error converting RA/Dec or Lat/Long headers to formatted string (angle or time format using casacore::MVAngle) when unit is pixel.
How does this PR solve the issue?
- Check if angle unit before formatting, else just use value + unit.
- Improved converting header unit for casacore Quantity.
- Improved error message for future failures: "Header error or no image HDUs found" instead of "No image hdus found".
Are there any companion PRs (frontend, protobuf)? No
Is there anything else that testers should know (e.g. exactly how to reproduce the issue)? Load image attached to issue, should load instead of error message.

Checklist

[x] changelog updated / ~no changelog update needed~
[x] e2e test passing / ~added corresponding fix~
[x] ~protobuf updated to the latest dev commit~ / no protobuf update needed
[x] added reviewers and assignee
[x] added ZenHub estimate, milestone, and release

github-actions[bot] commented 1 year ago

Package	Line Rate	Health
src.Cache	68%	➖
src.DataStream	52%	➖
src.FileList	67%	➖
src.Frame	51%	➖
src.HttpServer	43%	➖
src.ImageData	28%	❌
src.ImageFitter	89%	✔
src.ImageGenerators	52%	➖
src.ImageStats	74%	➖
src.Logger	44%	➖
src.Main	54%	➖
src.Region	19%	❌
src.Session	30%	❌
src.Table	52%	➖
src.ThreadingManager	87%	✔
src.Timer	85%	✔
src.Util	50%	➖
Summary	39% (6822 / 17605)	➖