Closed markccchiang closed 1 year ago
@markccchiang I have confirmed that the duplicated REGION_HISTOGRAM_DATA (the first one that is same to the original REGION_HISTOGRAM_DATA returned from OPEN_FILE request) problem has been solved. Now the ICD flow is [2023-05-18 08:43:54.288] [CARTA] [debug] [protocol] ==> REGION_HISTOGRAM_DATA [2023-05-18 08:43:55.867] [CARTA] [debug] [protocol] <== SET_HISTOGRAM_REQUIREMENTS Which is what we expect to.
The ICD test design has been updated!
@markccchiang I found big regression problems in this PR. ICD-RxJS failed on most PV related tests (7 tests), Moment related tests (5 tests), and Image fitting tests (3 tests). They are all lack "RegionHistogramData"
However your PR branch has NO "RegionHistogramData" and weird RasterTile Image
Once the frontend request 13 moment images, the backend should returned 13 "RegionHistogramData"
However your PR branch has NO "RegionHistogramData" and weird RasterTile Image
There should has two "RegionHistogramData" for one residual image and one model image.
However your PR branch has NO "RegionHistogramData" and weird RasterTile Image
And you can see in your PR, the bottom left "Render Configuration" there is no plots (i.e. no RegionHistogramData information)
Package | Line Rate | Health |
---|---|---|
src.Cache | 66% | ➖ |
src.DataStream | 52% | ➖ |
src.FileList | 67% | ➖ |
src.Frame | 50% | ➖ |
src.HttpServer | 43% | ➖ |
src.ImageData | 28% | ❌ |
src.ImageFitter | 89% | ✔ |
src.ImageGenerators | 44% | ➖ |
src.ImageStats | 76% | ✔ |
src.Logger | 44% | ➖ |
src.Main | 54% | ➖ |
src.Region | 18% | ❌ |
src.Session | 29% | ❌ |
src.Table | 52% | ➖ |
src.ThreadingManager | 87% | ✔ |
src.Timer | 85% | ✔ |
src.Util | 49% | ➖ |
Summary | 38% (6902 / 18257) | ❌ |
Description
What is implemented or fixed? Mention the linked issue(s), if any. Closes #1266.
How does this PR solve the issue? Give a brief summary. The backend only sends histogram data for the image rendering only when the channel is changed. There are also a few changes to clean up the codes.
Are there any companion PRs (frontend, protobuf)? No.
Is there anything else that testers should know (e.g. exactly how to reproduce the issue)? The duplicated histogram data for the image region should be gone now.
Checklist