CARTAvis / carta-backend

Source code repository for the backend component of CARTA, a new visualization tool designed for the ALMA, the VLA and the SKA pathfinders.
https://cartavis.github.io/
GNU General Public License v3.0
22 stars 11 forks source link

Sends histogram data for image rendering only when the channel is changed #1268

Closed markccchiang closed 1 year ago

markccchiang commented 1 year ago

Description

Checklist

acdo2002 commented 1 year ago

@markccchiang I have confirmed that the duplicated REGION_HISTOGRAM_DATA (the first one that is same to the original REGION_HISTOGRAM_DATA returned from OPEN_FILE request) problem has been solved. Now the ICD flow is [2023-05-18 08:43:54.288] [CARTA] [debug] [protocol] ==> REGION_HISTOGRAM_DATA [2023-05-18 08:43:55.867] [CARTA] [debug] [protocol] <== SET_HISTOGRAM_REQUIREMENTS Which is what we expect to.

The ICD test design has been updated!

acdo2002 commented 1 year ago

@markccchiang I found big regression problems in this PR. ICD-RxJS failed on most PV related tests (7 tests), Moment related tests (5 tests), and Image fitting tests (3 tests). They are all lack "RegionHistogramData"

  1. PV related dev ICD message flows should like Screen Shot 2023-05-19 at 1 04 13 AM

However your PR branch has NO "RegionHistogramData" and weird RasterTile Image

Screen Shot 2023-05-19 at 12 59 17 AM
  1. Moment related dev ICD message flows should like Screen Shot 2023-05-19 at 1 32 25 AM

    Once the frontend request 13 moment images, the backend should returned 13 "RegionHistogramData"

However your PR branch has NO "RegionHistogramData" and weird RasterTile Image

Screen Shot 2023-05-19 at 1 34 34 AM
  1. Image Fitting - show residual and model image dev ICD message flows should like Screen Shot 2023-05-19 at 1 15 58 AM

    There should has two "RegionHistogramData" for one residual image and one model image.

However your PR branch has NO "RegionHistogramData" and weird RasterTile Image

Screen Shot 2023-05-19 at 1 19 45 AM

And you can see in your PR, the bottom left "Render Configuration" there is no plots (i.e. no RegionHistogramData information)

github-actions[bot] commented 1 year ago

Code Coverage

Package Line Rate Health
src.Cache 66%
src.DataStream 52%
src.FileList 67%
src.Frame 50%
src.HttpServer 43%
src.ImageData 28%
src.ImageFitter 89%
src.ImageGenerators 44%
src.ImageStats 76%
src.Logger 44%
src.Main 54%
src.Region 18%
src.Session 29%
src.Table 52%
src.ThreadingManager 87%
src.Timer 85%
src.Util 49%
Summary 38% (6902 / 18257)