Closed pford closed 1 year ago
acdo2002
commented
1 year ago Because adding the syncId for RASTER_TILE_DATA and RASTER_TILE_SYNC, the ICD tests need to be updated, please merge it after finishing the ICD tests (otherwise the daily monitor tests will failed). I will let everyone know when the tests are finish the updates.
acdo2002
commented
1 year ago I have updated the tests code PR that can be passed on MacOS11 with this backend PR (and corresponding protobuf). Thanks for waiting!
github-actions[bot]
commented
1 year ago | Package | Line Rate | Health |
|---|---|---|
| src.Cache | 66% | ➖ |
| src.DataStream | 52% | ➖ |
| src.FileList | 67% | ➖ |
| src.Frame | 50% | ➖ |
| src.HttpServer | 43% | ➖ |
| src.ImageData | 28% | ❌ |
| src.ImageFitter | 89% | ✔ |
| src.ImageGenerators | 44% | ➖ |
| src.ImageStats | 76% | ✔ |
| src.Logger | 44% | ➖ |
| src.Main | 54% | ➖ |
| src.Region | 18% | ❌ |
| src.Session | 29% | ❌ |
| src.Table | 52% | ➖ |
| src.ThreadingManager | 87% | ✔ |
| src.Timer | 85% | ✔ |
| src.Util | 48% | ➖ |
| Summary | 38% (7012 / 18558) | ❌ |
Description
What is implemented or fixed? Mention the linked issue(s), if any.
1282
How does this PR solve the issue? Give a brief summary. With multithreading, there could be overlapping RasterTileSync/RasterTileData messages. Adding an id and a count to these messages helps the frontend sort them out.
Are there any companion PRs (frontend, protobuf)? frontend #2219, protobuf #87
Is there anything else that testers should know (e.g. exactly how to reproduce the issue)? See frontend issue #1988 Checklist
[x] changelog updated / ~no changelog update needed~
[x] e2e test passing / ~added corresponding fix~
[x] protobuf updated to the latest dev commit / ~no protobuf update needed~
[x] added reviewers and assignee
[x] added ZenHub estimate, milestone, and release