Mark/1312 Consider the angle unit string from IRAM FITS images - Githubissues

CARTAvis / carta-backend

Source code repository for the backend component of CARTA, a new visualization tool designed for the ALMA, the VLA and the SKA pathfinders.

https://cartavis.github.io/

GNU General Public License v3.0

22 stars 11 forks source link

Mark/1312 Consider the angle unit string from IRAM FITS images #1313

Closed markccchiang closed 1 year ago

markccchiang commented 1 year ago

Description

What is implemented or fixed? Mention the linked issue(s), if any. Closes #1312.
How does this PR solve the issue? Give a brief summary. Add a parser for the angle unit string from IRAM FITS images in the NormalizeUnit function.
Are there any companion PRs (frontend, protobuf)? No.
Is there anything else that testers should know (e.g. exactly how to reproduce the issue)? The IRAM FITS images can be opened now.

Checklist

[x] changelog updated ~/ no changelog update needed~
[x] e2e test passing / ~corresponding fix added~ / ~new e2e test created~
[x] ~protobuf updated to the latest dev commit /~ no protobuf update needed
[ ] added reviewers and assignee
[ ] added ZenHub estimate, milestone, and release

kswang1029 commented 1 year ago

@acdo2002 please validate the fix.

acdo2002 commented 1 year ago

Yes, I have confirmed the issue has been solved with this PR. Now the IRAM old data can be opened with this PR

github-actions[bot] commented 1 year ago

Package	Line Rate	Health
src.Cache	66%	➖
src.DataStream	52%	➖
src.FileList	67%	➖
src.Frame	50%	➖
src.HttpServer	42%	➖
src.ImageData	28%	❌
src.ImageFitter	83%	✔
src.ImageGenerators	43%	➖
src.ImageStats	76%	✔
src.Logger	44%	➖
src.Main	54%	➖
src.Region	18%	❌
src.Session	29%	❌
src.Table	52%	➖
src.ThreadingManager	87%	✔
src.Timer	85%	✔
src.Util	49%	➖
Summary	38% (7087 / 18701)	❌