CARTAvis / carta-backend

Source code repository for the backend component of CARTA, a new visualization tool designed for the ALMA, the VLA and the SKA pathfinders.
https://cartavis.github.io/
GNU General Public License v3.0
22 stars 11 forks source link

Mark/1281 Check if the frontend version is compatible #1316

Closed markccchiang closed 1 year ago

markccchiang commented 1 year ago

Description

Checklist

github-actions[bot] commented 1 year ago

Code Coverage

Package Line Rate Health
src.Cache 66%
src.DataStream 52%
src.FileList 67%
src.Frame 50%
src.HttpServer 42%
src.ImageData 28%
src.ImageFitter 83%
src.ImageGenerators 43%
src.ImageStats 76%
src.Logger 44%
src.Main 54%
src.Region 18%
src.Session 29%
src.Table 52%
src.ThreadingManager 87%
src.Timer 85%
src.Util 49%
Summary 38% (7090 / 18713)
confluence commented 1 year ago

I am closing this because of the decision to solve this issue with a different approach to the ICD version. We will still need changes in the backend to support the new approach (to use a single location in the protobuf repo to store the ICD version, and possibly also to use a flag to set the strictness level for the ICD comparison), but this should be done in new PRs.