Closed veggiesaurus closed 3 months ago
@pford Do you think this is on the right track? this is for loading HIPS files from the hips2fits service using cfitsio's ability to load from URL. Some of the changes are required to avoid opening files multiple times
@confluence can we assign this to you or @confluence for cleanup/testing once the frontend is fleshed out? (it's only scripting at the moment)
@pford this PR looks fine to me. Would you turn this as a formal one when you feel ready?
Package | Line Rate | Health |
---|---|---|
src.Cache | 72% | ➖ |
src.DataStream | 44% | ➖ |
src.FileList | 67% | ➖ |
src.Frame | 36% | ❌ |
src.HttpServer | 42% | ➖ |
src.ImageData | 28% | ❌ |
src.ImageFitter | 83% | ✔ |
src.ImageGenerators | 44% | ➖ |
src.ImageStats | 75% | ✔ |
src.Logger | 37% | ❌ |
src.Main | 52% | ➖ |
src.Region | 69% | ➖ |
src.Session | 4% | ❌ |
src.Table | 52% | ➖ |
src.ThreadingManager | 67% | ➖ |
src.Timer | 85% | ✔ |
src.Util | 38% | ❌ |
Summary | 46% (8641 / 18939) | ➖ |
Description Load files from the hips2fits server
What is implemented or fixed? Mention the linked issue(s), if any. Closes #1379
How does this PR solve the issue? Give a brief summary. Use CartaFitsLoader to open the file using the URL as the filename.
Are there any companion PRs (frontend, protobuf)? CARTAvis/carta-frontend#2346, CARTAvis/carta-protobuf#93
Is there anything else that testers should know (e.g. exactly how to reproduce the issue)? Load HiPS FITS image using the frontend data query UI.
Checklist