Check for stoi out_of_range for FITS header parsing

CARTAvis / carta-backend

Source code repository for the backend component of CARTA, a new visualization tool designed for the ALMA, the VLA and the SKA pathfinders.

GNU General Public License v3.0

22 stars 11 forks source link

Description

What is implemented or fixed? Mention the linked issue(s), if any. Fixes #1366
How does this PR solve the issue? Give a brief summary. Catch std::out_of_range exception from std::stoi and use std::stol instead.
Are there any companion PRs (frontend, protobuf)? No
Is there anything else that testers should know (e.g. exactly how to reproduce the issue)? FITS gz image attached in issue. Open without error or crash.

Checklist

[x] changelog updated / ~no changelog update needed~
[x] e2e test passing / corresponding fix added / new e2e test created
[ ] ICD test passing / corresponding fix added / new ICD test created
[x] ~protobuf updated to the latest dev commit~ / no protobuf update needed
[x] ~protobuf version bumped~ / protobuf version not bumped
[x] added reviewers and assignee
[x] added ZenHub estimate, milestone, and release

Package	Line Rate	Health
src.Cache	72%	➖
src.DataStream	44%	➖
src.FileList	67%	➖
src.Frame	36%	❌
src.HttpServer	42%	➖
src.ImageData	27%	❌
src.ImageFitter	83%	✔
src.ImageGenerators	43%	➖
src.ImageStats	75%	✔
src.Logger	37%	❌
src.Main	52%	➖
src.Region	69%	➖
src.Session	4%	❌
src.Table	52%	➖
src.ThreadingManager	67%	➖
src.Timer	85%	✔
src.Util	40%	➖
Summary	46% (8605 / 18783)	➖

Package

Line Rate

Health

src.Cache

72%

➖

src.DataStream

44%

➖

src.FileList

67%

➖

src.Frame

36%

❌

src.HttpServer

42%

➖

src.ImageData

27%

❌

src.ImageFitter

83%

✔

src.ImageGenerators

43%

➖

src.ImageStats

75%

✔

src.Logger

37%

❌

src.Main

52%

➖

src.Region

69%

➖

src.Session

❌

src.Table

52%

➖

src.ThreadingManager

67%

➖

src.Timer

85%

✔

src.Util

40%

➖

Summary

46% (8605 / 18783)

➖

CARTAvis / carta-backend

Check for stoi out_of_range for FITS header parsing #1369