Set rest frequency in moment generator - Githubissues

CARTAvis / carta-backend

Source code repository for the backend component of CARTA, a new visualization tool designed for the ALMA, the VLA and the SKA pathfinders.

https://cartavis.github.io/

GNU General Public License v3.0

22 stars 11 forks source link

Set rest frequency in moment generator #1387

Closed pford closed 2 months ago

pford commented 4 months ago

Description

What is implemented or fixed? Mention the linked issue(s), if any. Closes #1385
How does this PR solve the issue? Give a brief summary. Set MomentRequest rest frequency in MomentGenerator image coordinate system, then restore image rest freq after moment images created.
Are there any companion PRs (frontend, protobuf)? CARTAvis/carta-frontend#2404 + CARTAvis/carta-protobuf#98
Is there anything else that testers should know (e.g. exactly how to reproduce the issue)? Rest frequency will be added to Moment dialog in frontend.

Checklist

[x] changelog updated / ~no changelog update needed~
[x] e2e test passing / corresponding fix added / new e2e test created
[x] ICD test passing / corresponding fix added / new ICD test created
[x] protobuf updated to the latest dev commit / ~no protobuf update needed~
[x] protobuf minor version bumped / ~protobuf version not bumped~
[x] added reviewers and assignee
[ ] GitHub Project estimate added

kswang1029 commented 3 months ago

@pford this looks good to be a formal PR.

github-actions[bot] commented 2 months ago

Package	Line Rate	Health
src.Cache	72%	➖
src.DataStream	44%	➖
src.FileList	67%	➖
src.Frame	36%	❌
src.HttpServer	42%	➖
src.ImageData	28%	❌
src.ImageFitter	83%	✔
src.ImageGenerators	43%	➖
src.ImageStats	75%	✔
src.Logger	37%	❌
src.Main	52%	➖
src.Region	69%	➖
src.Session	4%	❌
src.Table	52%	➖
src.ThreadingManager	67%	➖
src.Timer	85%	✔
src.Util	38%	❌
Summary	46% (8641 / 18973)	➖