search

CARTAvis / carta-backend

Source code repository for the backend component of CARTA, a new visualization tool designed for the ALMA, the VLA and the SKA pathfinders.
https://cartavis.github.io/
GNU General Public License v3.0
22 stars 11 forks source link

Catalog data stream stopped after first return #758

Closed panchyo0 closed 3 years ago

panchyo0 commented 3 years ago

https://user-images.githubusercontent.com/22226157/109909406-49669c00-7c63-11eb-8938-19a13117a423.mp4

kswang1029 commented 3 years ago

could this be due to uWS update?

kswang1029 commented 3 years ago

@markccchiang could you investigate this?

markccchiang commented 3 years ago

@markccchiang could you investigate this?

Ok.

markccchiang commented 3 years ago

This problem can be solved if I enlarge the max backpressure for the uWebSockets. Say, setting .maxBackpressure = 256 * 1024 * 1024. Does this new value make sense?

veggiesaurus commented 3 years ago

@markccchiang what exactly does the max backpressure setting do? Does it limit the buffer size while sending? That might be essential when streaming large catalogs to slow networks

markccchiang commented 3 years ago

@markccchiang what exactly does the max backpressure setting do? Does it limit the buffer size while sending? That might be essential when streaming large catalogs to slow networks

Yes, the max backpressure limits the buffer size while sending. According to the code: 截圖 2021-03-04 下午4 54 37

veggiesaurus commented 3 years ago

@markccchiang what exactly does the max backpressure setting do? Does it limit the buffer size while sending? That might be essential when streaming large catalogs to slow networks

Yes, the max backpressure limits the buffer size while sending. According to the code: 截圖 2021-03-04 下午4 54 37

Ok, go ahead and increase it then. We've done the same sort of thing for the reverse direction anyway