performance impact of AST grid tolerance to wide field images

CARTAvis / carta-frontend

Source code repository for the frontend component of CARTA, a new visualization tool designed for the ALMA, the VLA and the SKA pathfinders.

https://cartavis.github.io/

GNU General Public License v3.0

20 stars 10 forks source link

performance impact of AST grid tolerance to wide field images #451

Open kswang1029 opened 5 years ago

kswang1029 commented 5 years ago

Currently, the minimum of grid tolerance is set to 0.1%. Screen Shot 2019-08-07 at 9 48 50 AM This is good for small field images in general.

However, if it is a wide field image such as the following, Screen Shot 2019-08-07 at 9 51 04 AM and if we click spinner "down" to have the tolerance to be 0.1%, the entire page becomes frozen. 1% still works fine in this case.

veggiesaurus commented 5 years ago

relabelled as a bug, since it can crash the frontend

Pietersielie commented 7 months ago

Merged by #460?

kswang1029 commented 7 months ago

Merged by #460?

Nope. The underlying issue remains (performance issue from astlib). #460 is just a workaround to lower the chance of having performance issue. A possible "solution" would be setting the tolerance dynamically based on the rendering area on screen.