search

CARTAvis / carta-frontend

Source code repository for the frontend component of CARTA, a new visualization tool designed for the ALMA, the VLA and the SKA pathfinders.
https://cartavis.github.io/
GNU General Public License v3.0
19 stars 10 forks source link

Synchronise contour and raster data when animating #569

Open veggiesaurus opened 4 years ago

veggiesaurus commented 4 years ago

Currently, raster and contour data is sent separately, and displayed as soon as its available. When animating, we should only display contour data once: (a) the contour data is complete (b) the animation data has been sent

This can initially be applied just to contours of the same file as the raster data. Once overlays are properly implemented, we can have a separate issue for synchronising display of contours across different files (much tricker...)

kswang1029 commented 3 years ago

related to https://app.zenhub.com/workspaces/carta-5c7fc74483f19a07c7bcacaf/issues/cartavis/carta-backend/849

kswang1029 commented 2 years ago

Steps to reproduce the issue: 1) load HD163296_CO_2_1.fits 2) append HD163296_13CO_2-1.fits 3) match them spatially and spectrally 4) generate contours using HD163296_13CO_2-1.fits as data source. Switch to channel 26 and use min-max to generate 20 levels 5) switch to single panel view mode 5) set HD163296_CO_2_1.fits active and animate it 6) now observe the features from the raster image and contour image in each channel, HD163296_CO_2_1.fits and HD163296_13CO_2-1.fits have similar emission line spatial features except their emission intensity. The issue is apparently we see contours and corresponding raster got rendered asynchronously. Contour seems to be rendered ahead of raster (even after the 2-ch offset bug is fixed).

https://user-images.githubusercontent.com/20819712/175016732-70fe2a1f-0f28-41a1-b31a-405129237973.mov