CARTAvis / carta-frontend

Source code repository for the frontend component of CARTA, a new visualization tool designed for the ALMA, the VLA and the SKA pathfinders.
https://cartavis.github.io/
GNU General Public License v3.0
20 stars 10 forks source link

Actions for cursor regions? #610

Open veggiesaurus opened 4 years ago

veggiesaurus commented 4 years ago

Should we just add the two actions (lock and center) to the cursor as well? The lock icon applied to the cursor region could be used to toggle frozen/unfrozen cursor, and there's no reason why you shouldn't be able to center on the cursor region, in my mind.

@kswang1029 @zarda thoughts on this?

kswang1029 commented 4 years ago

Good idea

arusstaylor commented 4 years ago

doesn't this work only if the cursor is already locked? How does this behave if the cursor is not locked? Isn't the cursor position then undefined because the mouse pointer is off the image?

kswang1029 commented 4 years ago

Could it be the case that we show those buttons only when cursor is locked? If it is free we show nothing.

veggiesaurus commented 4 years ago

doesn't this work only if the cursor is already locked? How does this behave if the cursor is not locked? Isn't the cursor position then undefined because the mouse pointer is off the image?

I guess this is only really useful if the cursor is already locked. But it does give the user another way to lock or unlock the cursor if they forget that F is the shortcut.

arusstaylor commented 4 years ago

Not the cannot be used to lock the cursor since the cursor is over the region widget not the image. We dont currently use the right click button for anything. I wonder if we could have a right click menu that has lock cursor as an option.