search

CARTAvis / carta-frontend

Source code repository for the frontend component of CARTA, a new visualization tool designed for the ALMA, the VLA and the SKA pathfinders.
https://cartavis.github.io/
GNU General Public License v3.0
20 stars 10 forks source link

unify AST usages thoroughly in the frontend codebase #787

Open kswang1029 opened 4 years ago

kswang1029 commented 4 years ago

Currently AST is used semi-independently elsewhere in the frontend codebase. It would be good to review and unify AST usages thoroughly in the frontend codebase for 1) better code maintainability 2) consistent AST calculations 3) re-usability for future feature development

aiming for v1.4

kswang1029 commented 4 years ago

These are possible AST usages:

FITS header integrity check spatial reference frame conversion Spectral reference frame conversion Intensity unit conversion Guard for invalid conversions Image FoV coverage check

veggiesaurus commented 4 years ago

I also think we should move towards reading the entire FITS header, and then extracting the sky and spectral frames, as @dsberry suggested

veggiesaurus commented 4 years ago

additional chore: update to AST 9.1.1 (after bugfix)

kswang1029 commented 2 years ago

@veggiesaurus need a status update.