CARTAvis / carta-frontend

Source code repository for the frontend component of CARTA, a new visualization tool designed for the ALMA, the VLA and the SKA pathfinders.
https://cartavis.github.io/
GNU General Public License v3.0
20 stars 10 forks source link

Additional symbols for catalog shapes #876

Closed veggiesaurus closed 4 years ago

veggiesaurus commented 4 years ago

we probably can apply some rotations to these symbol shapes like the attached image. For closed shape, we can set it as filled or not.

Screen Shot 2020-03-04 at 6 28 10 PM

Originally posted by @kswang1029 in https://github.com/CARTAvis/carta-frontend/issues/814#issuecomment-594442762

(In addition, the dropdown for selecting the shape should be changed to a BlueprintJS "Select", and should show the symbol shape, rather than the name)

panchyo0 commented 4 years ago

Should we also update the catalog file dropdown and system dropdown to BlueprintJS "Select"? UI for syetem dropdown:

Screen Shot 2020-04-28 at 7 49 24 PM

UI for shape dropdown:

Screen Shot 2020-04-28 at 7 49 01 PM

We can draw all shapes in Plotly (https://plotly.com/~dmiller123/4/name-circle-name-circle-open-name-circle-dot-name-circle-open-dot-name-square-na/#plot), However Blueprint icon doesn't have all icons (like triangle and hexagon). We might need to create our own SVG icons or using a static png file.

low-sky commented 4 years ago

I think(5-pointed) star symbol would be good to include.

Looking to the future, we'll also want to draw ellipses through this interface but that would be tricky. For example, lots of astronomical source catalogs fit an ellipse to sources so the symbols should map the major, minor, and position angle from a catalog to the same properties on plotting symbol. Like so:

Screen Shot 2020-04-29 at 1 33 35 PM
arusstaylor commented 4 years ago

agreed. this is very useful. But would require is to parse properties from multiple columns of a source catalogue.

veggiesaurus commented 4 years ago

Looking to the future, we'll also want to draw ellipses through this interface but that would be tricky. For example, lots of astronomical source catalogs fit an ellipse to sources so the symbols should map the major, minor, and position angle from a catalog to the same properties on plotting symbol

It's unlikely that plotly will support efficient rendering of multiple ellipses of different proportions, and the only way I can think of doing this is via some custom WebGL shaders. Could you create an issue for this, and we can continue the discussion there?