search

CARTAvis / carta

To CARTA users, this repo holds the CARTA release packages. Please use this repo to log bugs and feature requests. These will be triaged by the development team and prioritised as necessary in the development cycles.
19 stars 0 forks source link

feature request: spectra dynamic when the region moves #30

Open teuben opened 4 years ago

teuben commented 4 years ago

When the cursor moves, the X Y and Z slices dynamically change right away, this is very important for data browsing. But to increase signal to noise, a region can be better. But when I select a region, the spectrum is only updated after I've dropped the region in another location. Again, sorry for the comparison,but in ds9 the spectrum dynamically changed when the regions is moved, before you drop it again. This is a very useful feature. So if it's possible to do this....

kswang1029 commented 4 years ago

A quick response about why we require a drop action to trigger profile update is for the consideration of large cubes with lots of channels. With small cubes, calculating region spectral profile is quick (enough) to catch up the speed of cursor movement. This is not the case for large(r) cubes. What would happen in ds9 when there are lots of channels?🤔

teuben commented 4 years ago

yes, on ds9 it will slow you down when the region gets large, But perhaps like your recomput button somewhere else in carta, this could be an option to make it dynamic. I think most people will use smallish regions though, it took me years of ds9 usage until i ran into the slowness for large regions.

On Mon, Jun 22, 2020 at 10:50 AM Kuo-Song Wang notifications@github.com wrote:

A quick response about why we require a drop action to trigger profile update is for the consideration of large cubes with lots of channels. With small cubes, calculating region spectral profile is quick (enough) to catch up the speed of cursor movement. This is not the case for large(r) cubes. What would happen in ds9 when there are lots of channels?🤔

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/CARTAvis/carta/issues/30#issuecomment-647567139, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAZ4MGMZS7GKCICMM7R23XLRX5VSRANCNFSM4OEVJGYA .

veggiesaurus commented 4 years ago

When the cursor moves, the X Y and Z slices dynamically change right away, this is very important for data browsing. But to increase signal to noise, a region can be better. But when I select a region, the spectrum is only updated after I've dropped the region in another location. Again, sorry for the comparison,but in ds9 the spectrum dynamically changed when the regions is moved, before you drop it again. This is a very useful feature. So if it's possible to do this....

I think we may be able to handle this appropriately, now that we have region spectral profile cancellation working nicely. The problem is that for large files, this will be prohibitively slow, and will degrade performance in general. So we may need a region size threshold for this :thinking:

teuben commented 4 years ago

A fancy option might be (if you can program it) to threshold this on a preset delta-time, e.g. 500ms, once you detect that updates are not optimal. Users could then set their tolerance lower or higher. I would imagine if it's over the threshold, you would only update once the region was dropped again.