search

CARTAvis / carta

To CARTA users, this repo holds the CARTA release packages. Please use this repo to log bugs and feature requests. These will be triaged by the development team and prioritised as necessary in the development cycles.
19 stars 0 forks source link

Feature Request: Setting S > N as 0 degree for line region PA #95

Closed spectram closed 2 years ago

spectram commented 2 years ago

I use pvextractor from Astropy for producing slices but "the position angle is defined counter-clockwise from North, and the direction of the path is such that for a position angle of zero, the path is defined from South to North." This is consistent with slit positioning definitions (on sky PA) for long slit observations.

If this is not possible then, I recommend cautioning the user of the 90 degree phase shift in definitions.

kswang1029 commented 2 years ago

Thanks for the suggestion. We have already fixed the PA of the line region definition. It will be part of the v3-beta2 release.

spectram commented 2 years ago

@kswang1029 - Slightly unrelated: When I import regions that were exported from CARTA in the past, they are considerably offset. I couldn't see any reported issues regarding this. Shall I create one?

kswang1029 commented 2 years ago

@kswang1029 - Slightly unrelated: When I import regions that were exported from CARTA in the past, they are considerably offset. I couldn't see any reported issues regarding this. Shall I create one?

Yes please. Thank you.

kswang1029 commented 2 years ago

should have been addressed.