search

CARiSMA-Tool / carisma-tool

Implementation of the CARiSMA Tool
https://github.com/CARiSMA-Tool/carisma-tool
Eclipse Public License 1.0
3 stars 5 forks source link

Analysis Results: Unhandled event loop exception #4

Closed seiferma closed 4 years ago

seiferma commented 4 years ago

Everytime I try to open the context menu in the Analysis Results view, I get the following exception:

java.lang.RuntimeException: Unknown Selection: null
    at carisma.ui.eclipse.views.AnalysisResultsView$4.menuAboutToShow(AnalysisResultsView.java:183)
    at org.eclipse.jface.action.MenuManager.fireAboutToShow(MenuManager.java:339)
    at org.eclipse.jface.action.MenuManager.handleAboutToShow(MenuManager.java:470)
    at org.eclipse.jface.action.MenuManager.access$1(MenuManager.java:465)
    at org.eclipse.jface.action.MenuManager$2.menuShown(MenuManager.java:497)
    at org.eclipse.swt.widgets.TypedListener.handleEvent(TypedListener.java:256)
    at org.eclipse.swt.widgets.EventTable.sendEvent(EventTable.java:86)
    at org.eclipse.swt.widgets.Display.sendEvent(Display.java:4118)
    at org.eclipse.swt.widgets.Widget.sendEvent(Widget.java:1052)
    at org.eclipse.swt.widgets.Widget.sendEvent(Widget.java:1076)
    at org.eclipse.swt.widgets.Widget.sendEvent(Widget.java:1057)
    at org.eclipse.swt.widgets.Control.WM_INITMENUPOPUP(Control.java:5125)
    at org.eclipse.swt.widgets.Control.windowProc(Control.java:4794)
    at org.eclipse.swt.widgets.Canvas.windowProc(Canvas.java:345)
    at org.eclipse.swt.widgets.Decorations.windowProc(Decorations.java:1499)
    at org.eclipse.swt.widgets.Shell.windowProc(Shell.java:2159)
    at org.eclipse.swt.widgets.Display.windowProc(Display.java:4757)
    at org.eclipse.swt.internal.win32.OS.TrackPopupMenu(Native Method)
    at org.eclipse.swt.widgets.Menu._setVisible(Menu.java:250)
    at org.eclipse.swt.widgets.Display.runPopups(Display.java:3972)
    at org.eclipse.swt.widgets.Display.readAndDispatch(Display.java:3528)
    at org.eclipse.e4.ui.internal.workbench.swt.PartRenderingEngine$5.run(PartRenderingEngine.java:1170)
    at org.eclipse.core.databinding.observable.Realm.runWithDefault(Realm.java:336)
    at org.eclipse.e4.ui.internal.workbench.swt.PartRenderingEngine.run(PartRenderingEngine.java:1059)
    at org.eclipse.e4.ui.internal.workbench.E4Workbench.createAndRunUI(E4Workbench.java:153)
    at org.eclipse.ui.internal.Workbench.lambda$3(Workbench.java:667)
    at org.eclipse.core.databinding.observable.Realm.runWithDefault(Realm.java:336)
    at org.eclipse.ui.internal.Workbench.createAndRunWorkbench(Workbench.java:597)
    at org.eclipse.ui.PlatformUI.createAndRunWorkbench(PlatformUI.java:148)
    at org.eclipse.ui.internal.ide.application.IDEApplication.start(IDEApplication.java:152)
    at org.eclipse.equinox.internal.app.EclipseAppHandle.run(EclipseAppHandle.java:196)
    at org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.runApplication(EclipseAppLauncher.java:134)
    at org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.start(EclipseAppLauncher.java:104)
    at org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:388)
    at org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:243)
    at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
    at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
    at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
    at java.base/java.lang.reflect.Method.invoke(Method.java:566)
    at org.eclipse.equinox.launcher.Main.invokeFramework(Main.java:656)
    at org.eclipse.equinox.launcher.Main.basicRun(Main.java:592)
    at org.eclipse.equinox.launcher.Main.run(Main.java:1498)
    at org.eclipse.equinox.launcher.Main.main(Main.java:1471)

Looks like a minor issue. Most probably, this problem does not occur if there are entries that can be selected in the view.

SvenPeldszus commented 4 years ago

The context menu makes only sense if there are entries in the view. I added a null check in commit 5f8d8be to avoid this exception if no entry in the view is selected.