search

CAS-eResearch / TAOImport

TAO Data Conversion and Import Tools
GNU General Public License v3.0
2 stars 3 forks source link

Add a command-line flag to run in serial #16

Open manodeep opened 7 years ago

manodeep commented 7 years ago

taoconvert needs to have an user-specifed flag for serial mode and assume parallel mode by default.

Reason for defaulting to parallel mode is that if the user runs taoconvert without mpirun then the code will crash with MPI errors. However, if the default were to be serial, then the user could potentially want parallel and invoke with mpirun and still get serial code (+ associated data race conditions etc).

manodeep commented 7 years ago

Unclear if this is actually required. MPI_INIT should fail in the serial case and since that import is wrapped in a try/catch, the current implementation should work fine out of the box for MPI/serial runs simultaneously -- e.g., run in MPI mode when taoconvert is invoked with mpirun and in serial mode when taoconvert is directly invoked.

Leaving open until I confirm existence/absence of the usability issue.