Closed hsizek closed 2 years ago
@rionbr I don't know how GitHub's interface really works, so here is another modification that goes on top of the previous fork (#13 ). This modifies the same logic and has more details in the individual commits.
Hey @hsizek no problem, It also took me a while and I don't think I've fully mastered it yet :-) But I guess you can think of PR like a separate branch, where you can continue to push commits to it. When everybody is satisfied, the branch is merged to the master and the PR is closed.
I haven't forgot about this PR @hsizek. We are trying to finish the Effective Connectivity paper (on another branch) and then I will work on this, ok? Cheers!
Now that v0.1 is released we need to incorporate this @hsizek enhancement. A refactoring/cleaning of the TwoSymbol methods is probably in order. 👍
Two modifications: