Closed xuan-w closed 4 years ago
@xuan-w , I don't think you should change the output format. If I recall, we changed from int to str because it's faster. Can you adapt the derrida curve to fit the new format? Have you ran the nosetest to make sure this doesn't impact the rest of the package? Cheers!
Hi Rion,
Let me clarify two things.
Somehow github has problem to show the commits need to merge. It wrongly declared that there are 5 commits to be merged, actually there are only two. I merged all changed from master branch before sending the PR. If you look at "Filed changed" tab, you will see that actually there are only three lines change, they are on the DC function.
Github is getting weird! Since the previous PR was merged, there should be only on commit waiting for merge. But it showed two. Anyway, there are only two lines of difference.