CASELOAD7000 / knockback-sync

Synchronizes player knockback for smoother gameplay.
GNU General Public License v3.0
130 stars 19 forks source link

Support for older versions? #14

Open Ace-Monkey-Ilium opened 1 week ago

Ace-Monkey-Ilium commented 1 week ago

Would there be support for older versions such as 1.12.2 or any version before 1.18? If that wouldn't be too difficult to implement that would be amazing. Thanks

Axionize commented 1 week ago

It's on our TODO list actually. We have a few more higher priority items to tackle before next release (which will hopefully be tomorrow) and some minor feature improvements after that.

I can't give you a promise on exactly when this will happen, as we're not sure what path to take for backporting. Our current ideas are as follows:

Backport to 1.13 and then 1.9
on some older versions KB is fairly random, enough that we have to account for it, we have a few options:
1. Crack client side RNG
2. Simulate client code and apply random KB which may be different from client
3. Current implementation - easiest but will break vanilla-like behaviour
Ace-Monkey-Ilium commented 1 week ago

Glad to hear that! Would there also be a separate version of this for 1.8 and prior?

Axionize commented 1 week ago

Most 1.8 custom knockback plugins already address this issue by adjusting the knockback given to players in general and their use is implemented across most popular 1.8 PVP servers. We can probably make a small improvement upon the current standard without 1.8 but the small improvement, difficulty in porting an dominating support, and size of the userbase make supporting 1.8 unjustifiable

We won't port this to 1.8 unless we discover something we can do that would significantly benefit 1.8 servers that we don't currently know about or there is significant demand.

Axionize commented 16 hours ago

We now support 1.16.5 to 1.21.X. I'm currently working on many things including backporting to older versions. What's the oldest version you need support for?

Axionize commented 6 hours ago

I've finished backporting. We now support 1.12.2 -> 1.21.X. We will not be backporting any further unless there is an explicit need. https://modrinth.com/plugin/knockbacksync